Thread (25 messages) flat view 25 messages, 5 authors, 2015-10-22

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

From: punit vara <hidden>
Date: 2015-10-22 18:23:25
Also in: lkml

On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov
[off-list ref] wrote:
On 10/21/2015 05:55 PM, Punit Vara wrote:
quoted
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:

Unneeded variable: "ret". Return "0" on line 980

Remove unneeded variable ret created to return zero.

Signed-off-by: Punit Vara <redacted>
---
  drivers/net/wireless/ath/wcn36xx/main.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c
b/drivers/net/wireless/ath/wcn36xx/main.c
index 7c169ab..82982d5 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -935,7 +935,6 @@ static const struct ieee80211_ops wcn36xx_ops = {

  static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
  {
-       int ret = 0;
  This empty line should be removed too.
quoted
        static const u32 cipher_suites[] = {
                WLAN_CIPHER_SUITE_WEP40,
[...]

MBR, Sergei
I have resend this patch as you said Sergei . Thanks for feedback ..
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help