From: Punit Vara <hidden> Date: 2015-10-21 14:56:52
This patch is to the ath10k/pci.h file that fixes following warning
reported by coccicheck:
WARNING: sum of probable bitmasks, consider |
I have replaced + with OR operator | for summing bitmasks
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:57:03
This patch is to the htt_rx.c that removes unneeded semicolon which is
reported by coccicheck.
Here semicolon just create empty statement so please remote it.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:57:15
This patch is to the ath10k/wmi.h that removes unneeded semicolon which
is reported by coccicheck.
Here semicolon just create empty statement so please remote it.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath10k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:57:30
This patch is to the libipw_rx.c file that fixes following warning
reported by coccicheck:
WARNING: sum of probable bitmasks, consider |
I have replaced + with OR operator | for summing bitmasks
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ipw2x00/libipw_rx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -875,7 +875,7 @@ void libipw_rx_any(struct libipw_device *ieee,caseIW_MODE_ADHOC:/* our BSS and not from/to DS */if(ether_addr_equal(hdr->addr3,ieee->bssid))-if((fc&(IEEE80211_FCTL_TODS+IEEE80211_FCTL_FROMDS))==0){+if((fc&(IEEE80211_FCTL_TODS|IEEE80211_FCTL_FROMDS))==0){/* promisc: get all */if(ieee->dev->flags&IFF_PROMISC)is_packet_for_us=1;
@@ -890,7 +890,7 @@ void libipw_rx_any(struct libipw_device *ieee,caseIW_MODE_INFRA:/* our BSS (== from our AP) and from DS */if(ether_addr_equal(hdr->addr2,ieee->bssid))-if((fc&(IEEE80211_FCTL_TODS+IEEE80211_FCTL_FROMDS))==IEEE80211_FCTL_FROMDS){+if((fc&(IEEE80211_FCTL_TODS|IEEE80211_FCTL_FROMDS))==IEEE80211_FCTL_FROMDS){/* promisc: get all */if(ieee->dev->flags&IFF_PROMISC)is_packet_for_us=1;
From: Punit Vara <hidden> Date: 2015-10-21 14:57:40
This patch is to the wlcore/acx.c file that fixes up warning
reported by coccicheck:
WARNING: end returns can be simplified if negative or 0 value
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ti/wlcore/acx.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:57:52
Remove uncessary repeated arguments COMP_EFUSE, COMP_REGD, COMP_CHAN
with OR(|)
This is patch to the debug.c file that removes following warning
reported by coccicheck:
-duplicated argument to & or |
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/rtlwifi/debug.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:58:04
Remove uncessary repeated arguments with OR(|)
This is patch to the brcmsmac/channel.c file that removes following
warning reported by coccicheck:
-duplicated argument to & or |
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/brcm80211/brcmsmac/channel.c | 1 -
1 file changed, 1 deletion(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:58:15
This patch is to the at76c50x-usb.c file that fixes up warning
reported by coccicheck:
WARNING: end returns can be simplified if negative or 0 value
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/at76c50x-usb.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:58:27
This patch is to the zd1201.c file that fixes up warning
reported by coccicheck:
WARNING: end returns can be simplified and declaration on line 1658 can
be dropped
Prefer direct return value instead of writing 2-3 more sentence.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/zd1201.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:58:39
This patch is to the carl9170/phy.c file that fixes warning reported by
coccicheck :
WARNING: end returns can be simplified
I have removed unneccessary variable declaration and simply return flow
for carl9170_regwrite_result()
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/carl9170/phy.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:58:51
This patch is to the 3945-mac.c file that fixes up following warning
by coccicheck:
drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable:
"ret". Return "- EOPNOTSUPP" on line 249
Return -EOPNOTSUPP directly instead of return using ret
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/iwlegacy/3945-mac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
This patch is to the ath10k/pci.h file that fixes following warning
reported by coccicheck:
WARNING: sum of probable bitmasks, consider |
I have replaced + with OR operator | for summing bitmasks
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:59:03
This is patch to the brcmsmac/main.c that removes unnecessary variable
which was declared to return zero.
This patch fixes up warning reported by coccicheck:
-Unneeded variable: "err". Return "0" on line 3788
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/brcm80211/brcmsmac/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
@@ -3777,7 +3777,6 @@ static void brcms_c_set_ps_ctrl(struct brcms_c_info *wlc)*/staticintbrcms_c_set_mac(structbrcms_bss_cfg*bsscfg){-interr=0;structbrcms_c_info*wlc=bsscfg->wlc;/* enter the MAC addr into the RXE match registers */
@@ -3785,7 +3784,7 @@ static int brcms_c_set_mac(struct brcms_bss_cfg *bsscfg)brcms_c_ampdu_macaddr_upd(wlc);-returnerr;+return0;}/* Write the BSS config's BSSID address to core (set_bssid in d11procs.tcl).
From: Punit Vara <hidden> Date: 2015-10-21 14:59:19
This patch is to the brcmsmac/stf.c that fixes up warning caught by
coccicheck:
-Unneeded variable: "ret_code". Return "0" on line 328
Remove unneccesary variable ret_code created to return zero.
Siged-off-by: Punit Vara [off-list ref]
---
drivers/net/wireless/brcm80211/brcmsmac/stf.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:59:37
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:
-Unneeded variable: "ret". Return "0" on line 1733
Remove unneccesary variable ret created to return zero.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath5k/eeprom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Punit Vara <hidden> Date: 2015-10-21 14:59:49
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:
Unneeded variable: "ret". Return "0" on line 980
Remove unneeded variable ret created to return zero.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/wcn36xx/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: kbuild test robot <hidden> Date: 2015-10-21 15:47:23
Hi Punit,
[auto build test WARNING on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
url: https://github.com/0day-ci/linux/commits/Punit-Vara/Fix-warnings-reported-by-coccicheck/20151021-230937
config: x86_64-allyesconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/net/wireless//ti/wlcore/acx.c: In function 'wl1271_acx_mem_map':
From: Sergei Shtylyov <hidden> Date: 2015-10-21 21:43:56
Hello.
On 10/21/2015 05:55 PM, Punit Vara wrote:
This patch is to the ath10k/pci.h file that fixes following warning
pci.c, you mean?
quoted hunk
reported by coccicheck:
WARNING: sum of probable bitmasks, consider |
I have replaced + with OR operator | for summing bitmasks
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
From: Sergei Shtylyov <hidden> Date: 2015-10-21 21:45:47
On 10/21/2015 05:55 PM, Punit Vara wrote:
quoted hunk
This patch is to the 3945-mac.c file that fixes up following warning
by coccicheck:
drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable:
"ret". Return "- EOPNOTSUPP" on line 249
Return -EOPNOTSUPP directly instead of return using ret
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/iwlegacy/3945-mac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
From: Sergei Shtylyov <hidden> Date: 2015-10-21 21:46:54
On 10/21/2015 05:55 PM, Punit Vara wrote:
quoted hunk
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:
Unneeded variable: "ret". Return "0" on line 980
Remove unneeded variable ret created to return zero.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/wcn36xx/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: punit vara <hidden> Date: 2015-10-22 18:22:30
On Thu, Oct 22, 2015 at 3:13 AM, Sergei Shtylyov
[off-list ref] wrote:
Hello.
On 10/21/2015 05:55 PM, Punit Vara wrote:
quoted
This patch is to the ath10k/pci.h file that fixes following warning
pci.c, you mean?
quoted
reported by coccicheck:
WARNING: sum of probable bitmasks, consider |
I have replaced + with OR operator | for summing bitmasks
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/ath10k/pci.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
ath10k *ar)
switch (ar->hw_rev) {
case ATH10K_HW_QCA988X:
case ATH10K_HW_QCA6174:
- val = ath10k_pci_read32(ar, SOC_CORE_BASE_ADDRESS +
+ val = ath10k_pci_read32(ar, SOC_CORE_BASE_ADDRESS |
CORE_CTRL_ADDRESS);
val |= CORE_CTRL_PCIE_REG_31_MASK;
- ath10k_pci_write32(ar, SOC_CORE_BASE_ADDRESS +
+ ath10k_pci_write32(ar, SOC_CORE_BASE_ADDRESS |
CORE_CTRL_ADDRESS, val);
And these too.
[...]
MBR, Sergei
CORE_CTRL_ADDRESS is 0x0000 so it will not mask .. these patch should
be rejected ...I have modified by looking at coccicheck .Actually
First time I have used that tool I do know it can also generate false
warning sometime .I have experience about checkpatch.pl ..Sorry for
this patch rest I have resend
From: punit vara <hidden> Date: 2015-10-22 18:23:25
On Thu, Oct 22, 2015 at 3:16 AM, Sergei Shtylyov
[off-list ref] wrote:
On 10/21/2015 05:55 PM, Punit Vara wrote:
quoted
This patch is to the ath5k/eeprom.c that fixes up warning caught by
coccicheck:
Unneeded variable: "ret". Return "0" on line 980
Remove unneeded variable ret created to return zero.
Signed-off-by: Punit Vara <redacted>
---
drivers/net/wireless/ath/wcn36xx/main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)