Thread (25 messages) flat view 25 messages, 5 authors, 2015-10-22

Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

From: Jiri Slaby <hidden>
Date: 2015-10-21 15:00:38
Also in: lkml

On 10/21/2015, 04:55 PM, Punit Vara wrote:
quoted hunk ↗ jump to hunk
@@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
 static int at76_remap(struct usb_device *udev)
 {
 	int ret;
-	ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
+	return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
 			      USB_TYPE_VENDOR | USB_DIR_OUT |
 			      USB_RECIP_INTERFACE, 0, 0, NULL, 0,
 			      USB_CTRL_GET_TIMEOUT);
-	if (ret < 0)
-		return ret;
-	return 0;
ret is now unused, right?

-- 
js
suse labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help