Re: [PATCH 08/15] net: wireless: simplify return flow for usb_control_msg

On Wed, Oct 21, 2015 at 8:30 PM, Jiri Slaby [off-list ref] wrote:

On 10/21/2015, 04:55 PM, Punit Vara wrote:

quoted

@@ -544,13 +544,10 @@ static void at76_ledtrig_tx_activity(void)
 static int at76_remap(struct usb_device *udev)
 {
      int ret;
-     ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
+     return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a,
                            USB_TYPE_VENDOR | USB_DIR_OUT |
                            USB_RECIP_INTERFACE, 0, 0, NULL, 0,
                            USB_CTRL_GET_TIMEOUT);
-     if (ret < 0)
-             return ret;
-     return 0;

ret is now unused, right?

--
js
suse labs

Oppp..Sorry I have missed int ret to remove . I will resend the
updated patch soon