Thread (25 messages) flat view 25 messages, 5 authors, 2015-10-22

Re: [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret

From: Sergei Shtylyov <hidden>
Date: 2015-10-21 21:45:47
Also in: lkml

On 10/21/2015 05:55 PM, Punit Vara wrote:
quoted hunk ↗ jump to hunk
This patch is to the 3945-mac.c file that fixes up following warning
by coccicheck:

drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable:
"ret". Return "- EOPNOTSUPP" on line 249

Return -EOPNOTSUPP directly instead of return using ret

Signed-off-by: Punit Vara <redacted>
---
  drivers/net/wireless/iwlegacy/3945-mac.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c
index af1b3e6..ff4dc44 100644
--- a/drivers/net/wireless/iwlegacy/3945-mac.c
+++ b/drivers/net/wireless/iwlegacy/3945-mac.c
[...]
quoted hunk ↗ jump to hunk
@@ -529,7 +527,6 @@ il3945_tx_skb(struct il_priv *il,
  		if (unlikely(tid >= MAX_TID_COUNT))
  			goto drop;
  	}
-
    Unrelated whitespace change.
  	/* Descriptor for chosen Tx queue */
  	txq = &il->txq[txq_id];
  	q = &txq->q;
MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help