Re: [PATCH V2 09/12] net/eipoib: Add main driver functionality

On Sun, Aug 12, 2012 at 04:15:52PM +0300, Or Gerlitz wrote:

On 12/08/2012 13:22, Michael S. Tsirkin wrote:

quoted

quoted

quoted

quoted

quoted

- IGMP/MAC snooping in a driver is just too hairy.

quoted

mmm, any rough idea/direction how to do that otherwise?

Sure, even two ways, ideally you'd do both:)
A. fix macvtap
1. Use netdev_for_each_mc_addr etc to get multicast addresses
2. teach macvtap to fill that in (it currently floods multicasts
   for guest to guest communication so we ned to fix it anyway)

B. fix bridge
   teach bridge to work for VMs without using promisc mode

I wasn't sure to fully follow... need some more bits of info, the
macvtap fix
relates only to IGMP snooping, correct? as for the bridge fix, does
this somehow
relates to ARP snooping we do in the driver? how?

Or.

I didn't realize you do ARP snooping. Why?

I know you mangle outgoing ARP packets, this will go
away if you maintain a mapping in SM accessible to all guests.

-- 
MST