Re: [PATCH V2 06/12] net/core: Add rtnetlink support to vif parameters

On 8/2/2012 3:20 AM, Ben Hutchings wrote:

On Wed, 2012-08-01 at 20:09 +0300, Or Gerlitz wrote:

quoted

From: Erez Shitrit <redacted>

Add IFLA_VIF_INFO which allows user space to configure mac/vlan for a VIF

[...]

quoted

--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c

@@ -780,7 +780,8 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
  	       + rtnl_vfinfo_size(dev, ext_filter_mask) /* IFLA_VFINFO_LIST */
  	       + rtnl_port_size(dev) /* IFLA_VF_PORTS + IFLA_PORT_SELF */
  	       + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
-	       + rtnl_link_get_af_size(dev); /* IFLA_AF_SPEC */
+	       + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
+	       + nla_total_size(sizeof(struct ifla_vif_param)); /* IFLA_VIF_INFO */
  }

[...]

if_nlmsg_size() returns the size of a message describing the interface.
But IFLA_VIF_INFO is write-only (why?) and therefore shouldn't be
included.

Ben.

thanks, we missed that.
currently, we don't expose the vifs on its parent interface, we need to 
think if we want to expose it, if yes we will add "get" option, 
otherwise we will take it from if_nlmsg_size() function.