Re: [PATCH V2 08/12] net/eipoib: Add ethtool file support
From: Ben Hutchings <hidden>
Date: 2012-08-02 00:22:39
On Wed, 2012-08-01 at 20:09 +0300, Or Gerlitz wrote:
From: Erez Shitrit <redacted> Via ethtool the driver describes its version, ABI version, on what PIF interface it runs and various statistics.
[...]
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/net/eipoib/eth_ipoib_ethtool.c
[...]
+static void parent_ethtool_get_drvinfo(struct net_device *parent_dev,
+ struct ethtool_drvinfo *drvinfo)
+{
+ struct parent *parent = netdev_priv(parent_dev);
+
+ strncpy(drvinfo->driver, DRV_NAME, 32);
+
+ strncpy(drvinfo->version, DRV_VERSION, 32);
+
+ strncpy(drvinfo->bus_info, parent->ipoib_main_interface,
+ ETHTOOL_BUSINFO_LEN);These must be null-terminated; therefore use strlcpy().
+ /* indicates ABI version */ + snprintf(drvinfo->fw_version, 32, "%d", EIPOIB_ABI_VER);
[...] This is an abuse of fw_version. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.