Re: [PATCH V2 05/12] net: Add ndo_set_vif_param operation to serve eIPoIB VIFs
From: Erez Shitrit <hidden>
Date: 2012-08-02 08:25:33
On 8/2/2012 3:17 AM, Ben Hutchings wrote:
On Wed, 2012-08-01 at 20:09 +0300, Or Gerlitz wrote:quoted
From: Erez Shitrit <redacted> The Ethernet IPoIB driver enslaves IPoIB devices and uses them as VIFs (Virtual Interface) which serve an Ethernet NIC e.g present in a guest OS. For each such slave that acts as a VIF, eIPoIB needs to know the mac and optionally the vlan uses by that NIC, the new ndo opertaion is used to associate the mac/vlan for that slave. Signed-off-by: Erez Shitrit <redacted> Signed-off-by: Or Gerlitz <redacted> --- include/linux/netdevice.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index eb06e58..2709551 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h@@ -1013,7 +1013,10 @@ struct net_device_ops { netdev_features_t features); int (*ndo_neigh_construct)(struct neighbour *n); void (*ndo_neigh_destroy)(struct neighbour *n); - + int (*ndo_set_vif_param) (struct net_device *dev, + struct net_device *vif, + u16 vlan, + u8 *mac);The semantics of this operation should be documented in the comment above the structure definition. One detail worth covering is whether 'vlan' is just a VID or can also include priority+CFI bits.
We will add more documentation for that. The idea was just for the VID, (in our driver at least)
If this is specific to eIPoIB, why not put that in the name of the operation? If not, this *really* needs explaining because so far I have no whether it is something I should consider implementing on a real Ethernet device. Ben.
Will add more documentation here, perhaps other drivers can use it as well for visualization uses and more. Thanks.
quoted
int (*ndo_fdb_add)(struct ndmsg *ndm, struct net_device *dev, unsigned char *addr,