Hi Randy.
Randy Dunlap wrote:

Just a couple of nits here (below):

quoted

+++ b/include/linux/caif/caif_config.h

...

quoted

+struct caif_channel_config {
+	char name[16];
+	enum caif_channel_type type;
+	unsigned priority;
+	enum caif_phy_preference phy_pref;
+	char phy_name[16];
+
+	/** Union of channel type-specific configuration parameters.

Don't use /** here.

OK,

quoted

+
+/**
+ * struct ifcaif_param - Parameters for creating CAIF Network
Interface. + * + * When using SIOCCAIFNETNEW to create a CAIF IP
interface, this +structure + * is used for configuration data.
+ * The attribute ifr_ifru.ifru_data in struct struct ifreq must be
+set + * point at an instance of struct ifcaif_param.
+ *
+ * @ipv4_connid:  Connection ID for IPv4 PDP Context.
+ * @ipv6_connid:  Connection ID for IPv6 PDP Context.
+ * @loop:	  If different from zero, device is doing loopback + */
+struct ifcaif_param {
+	__u32			ipv4_connid;
+	__u32			ipv6_connid;
+	__u8			loop;
+};
+
+/**
+ * enum ifla_caif

Above line needs " - <short description>" on it.

Sure, I'll add that - thanks.

BR/Sjur