Thread (46 messages) 46 messages, 4 authors, 2010-02-02

RE: [PATCH net-next-2.6 03/13] net-caif: add CAIF generic protocol stack header files

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2010-01-22 10:11:03

Hi Sjur,
quoted
quoted
Add include files for the generic CAIF protocol stack. This layer is
somewhat generic in order to be able to use and test it outside the
Linux Kernel.

caif_layer.h - Defines the structure of the CAIF protocol layers
cfcnfg.h     - CAIF Configuration Module for services and link layers
cfctrl.h     - CAIF Control Protocol Layer
cffrml.h     - CAIF Framing Layer
cfglue.h     - CAIF Glue Layer for allocation, logging etc
cflist.h     - CAIF List implementation
cfmuxl.h     - CAIF Muxing Layer
cfpkt.h	     - CAIF Packet layer (skb helper functions)
cfserl.h     - CAIF Serial Layer
cfsrvl.h     - CAIF Service Layer
is it really needed to keep the "generic" piece in the path here. I
would prefer if we get rid of it. 
Are you suggesting to move this files to include/net/caif? 
I can do this in the next patch set.
The reason for the term "generic" is that this that the core part of the CAIF
stack originally was designed to be OS independent. 
I understand where you are coming from, but for the Linux implementation
it doesn't really sound like a good idea. Especially with the move to a
socket based implementation you really diverge here already.

Also the cfglue.[ch] pieces are really controversial. I would prefer not
to have OS glue code here. Just use native lists, locks etc. It makes
the code a lot easier to review for all the Linux people ;)

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help