RE: [PATCH net-next-2.6 03/13] net-caif: add CAIF generic protocol stack header files
From: Sjur Brændeland <hidden>
Date: 2010-01-22 11:02:49
From: Sjur Brændeland <hidden>
Date: 2010-01-22 11:02:49
Hi Patrick. Patrick McHardy wrote:
sjur.brandeland@stericsson.com wrote:quoted
+++ b/include/net/caif/generic/cfglue.h
...
This file looks like it should go away completely.
...
Why are you not using the list.h functions?
I kind of expected this feedback. The reason is that CAIF originally was written as a OS independent stack, with a thin glue layer for OS specific things. I am aware that this is not the preferred way of doing it in the Linux kernel. As mentioned to Marcel Holtmann, my problem is that I have more than 50 unit tests in User Space that I might have to ditch if I remove cfglue.h and list.h. But I'll probably do as you suggest in the next patch set... BR/Sjur