Re: [PATCH 2/5] netdev: bfin_mac: fix malformed UDP packet transmission when polling with KGDB
From: Mike Frysinger <hidden>
Date: 2009-05-29 11:42:13
From: Mike Frysinger <hidden>
Date: 2009-05-29 11:42:13
On Fri, May 29, 2009 at 07:27, David Miller wrote:
From: Mike Frysinger <redacted>quoted
that isnt how the DMA is being used here. there is no register to read back because the DMA controller is doing the reading indirectly. but along those lines, it's not entirely clear which DMA registers this SSYNC is supposed to be protecting because all of the updates are happening on the descriptors in external memory, not the DMA registers themselves. i'll have Sonic clarify.Yes, that's really confusing because the commit message says "registers".
the SSYNC() is still correct, but the comment is wrong/misleading as it isnt protecting the DMA registers, it's flushing the internal write buffers -mike