Re: [PATCH 3/5] netdev: bfin_mac: fix performance issue found by netperf
From: David Miller <davem@davemloft.net>
Date: 2009-05-29 09:05:54
From: Mike Frysinger <redacted> Date: Wed, 27 May 2009 02:10:13 -0400
quoted hunk ↗ jump to hunk
@@ -606,86 +606,28 @@ static int bfin_mac_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) { u16 *data; - + u32 data_align = (u32)(skb->data) & 0x3;
A pointer is not castable directly to a u32 everywhere. It can be 64-bits and in which case GCC will warn here. I know this is a blackfin specific driver, but please write portable code. Use "unsigned long" or similar. I'm not applying this as it is now.