Re: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared
From: Mike Frysinger <hidden>
Date: 2009-05-29 11:22:04
From: Mike Frysinger <hidden>
Date: 2009-05-29 11:22:04
On Fri, May 29, 2009 at 07:14, David Miller wrote:
From: "Hennerich, Michael" <Michael.Hennerich@analog.com>quoted
Our handler isn't prepared to handle such fake interrupts. So two options: 1) Set the proper IRQF flags. 2) Fix the ISR to handle spurious interrupts. This patch chose option 1)And to go back to my initial reply, I'm saying to do the "right thing" and go with #2 if you can :-)
and the answer is that doesnt make sense. why implement extra over head in an interrupt handler to support an operating mode the hardware can never support. if the IRQ could actually be shared, then sure, we should check things. but it cant, so you're suggesting we waste time in an IRQ handler for absolutely no gain. -mike