Re: [PATCH take 2] pkt_sched: Fix qdisc_watchdog() vs. dev_deactivate() race
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-14 06:16:20
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-14 06:16:20
On Sat, Sep 13, 2008 at 10:54:08PM +0200, Jarek Poplawski wrote:
If I get it right peek + dequeue should do all current dequeue logic plus additionally write down the child qdisc or skb (leaves) info, plus, probably, some ifs btw., which looks like a bit of overhead, if we consider requeuing as something exceptional. Unless we don't - then of course something like this could be useful.
I don't see the overhead in writing down something that we alrady have. In any case, do you have an alternative solution to the current problem that qdisc_run looks at an arbitrary queue's status to decide whether it should process a qdisc that empties into n queues? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt