Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-08-21 13:12:24
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-08-21 13:12:24
On Thu, Aug 21, 2008 at 12:55:01PM +0000, Jarek Poplawski wrote:
Alas I've to have a break now, anyway I think for now "my" proposal should be safer since it worked like this before... But of course after good checking your patch should be better.
Well your patch doesn't work and my patch doesn't compile :) The problem is that qdisc_lookup walks through every txq's list while the sch_tree_lock protects a single txq only. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt