Re: [PATCH take 2] pkt_sched: Fix qdisc_watchdog() vs. dev_deactivate() race
From: Jarek Poplawski <hidden>
Date: 2008-09-11 12:34:16
From: Jarek Poplawski <hidden>
Date: 2008-09-11 12:34:16
On Thu, Sep 11, 2008 at 09:54:49PM +1000, Herbert Xu wrote:
On Thu, Sep 11, 2008 at 11:51:32AM +0000, Jarek Poplawski wrote:quoted
IMHO, the most reasonable test here is for all tx_queues of a qdisc beeing stopped, but since this is quite heavy, probably we need an additional qdisc flag for such an occasion.
...
So I don't think there's anything inherently advantageous in checking all the queues.
BTW, I hope I wasn't misunderstood here. I don't mean any additional checking of all the queues anywhere. It's only about setting such a flag at the end of netif_stop_all_queues() and netif_stop_queue(). Jarek P.