Re: [PATCH take 2] pkt_sched: Fix qdisc_watchdog() vs. dev_deactivate() race
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-11 10:45:38
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-11 10:45:38
On Thu, Sep 11, 2008 at 03:39:56AM -0700, David Miller wrote:
I got to looking into this and we do need the qdisc->dev_queue member, see qdisc_run(). So it's not like we can get rid of it if we replace it with ->netdevdev and add a ->root_qdisc backpointer as well.
That can't be right. Let's I've got a single qdisc shared by n queues. It makes no sense for qdisc_run to decide to whether it should process the qdisc depending on the status of a single one out of the n queues. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt