Re: [PATCH take 2] pkt_sched: Fix qdisc_watchdog() vs. dev_deactivate() race
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-11 11:54:55
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2008-09-11 11:54:55
On Thu, Sep 11, 2008 at 11:51:32AM +0000, Jarek Poplawski wrote:
IMHO, the most reasonable test here is for all tx_queues of a qdisc beeing stopped, but since this is quite heavy, probably we need an additional qdisc flag for such an occasion.
Yes we could do that too. Although the head-of-qdisc approach will eventually lead to the same result. That is, as you pop things off the head eventually you'll hit a packet that belongs to the stopped queue and that'll then block the whole qdisc. So I don't think there's anything inherently advantageous in checking all the queues. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt