Re: [PATCH] devinet: inetdev_init out label moved after RCU assignment
From: David Stevens <hidden>
Date: 2007-01-05 19:53:05
From: David Stevens <hidden>
Date: 2007-01-05 19:53:05
Yeah, sure.
+-DLS
Acked-by: David L Stevens <redacted>
Signed-off-by: Jarek Poplawski <redacted> --- diff -Nurp linux-2.6.20-rc3-/net/ipv4/devinet.c
linux-2.6.20-rc3/net/ipv4/devinet.c
--- linux-2.6.20-rc3-/net/ipv4/devinet.c 2007-01-05 11:53:16.000000000
+0100
+++ linux-2.6.20-rc3/net/ipv4/devinet.c 2007-01-05 11:55:32.000000000
+0100
@@ -174,9 +174,10 @@ struct in_device *inetdev_init(struct ne ip_mc_init_dev(in_dev); if (dev->flags & IFF_UP) ip_mc_up(in_dev); -out: + /* we can receive as soon as ip_ptr is set -- do this last */ rcu_assign_pointer(dev->ip_ptr, in_dev); +out: return in_dev; out_kfree: kfree(in_dev); -To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html