Thread (98 messages) 98 messages, 14 authors, 14h ago

Re: [patch 09/18] entry: Remove syscall_enter_from_user_mode()

From: Thomas Gleixner <tglx@kernel.org>
Date: 2026-07-08 22:08:14
Also in: linux-alpha, linux-arch, linux-doc, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, linux-um, lkml, loongarch, sparclinux

On Wed, Jul 08 2026 at 17:21, Radu Rendec wrote:
On Tue, 2026-07-07 at 21:06 +0200, Thomas Gleixner wrote:
quoted
All architecture use either:

    nr = enter_from_user_mode_randomize_stack(regs, nr);
You probably mean syscall_enter_from_user_mode_randomize_stack.
Duh. I obviously got that wrong in a hurry. Thanks for pointing it out!
quoted
 static __always_inline bool report_single_step(unsigned long work)
 {
--- a/include/linux/irq-entry-common.h
+++ b/include/linux/irq-entry-common.h
@@ -49,9 +49,9 @@
  * Defaults to an empty implementation. Can be replaced by architecture
  * specific code.
  *
- * Invoked from syscall_enter_from_user_mode() in the non-instrumentable
- * section. Use __always_inline so the compiler cannot push it out of line
- * and make it instrumentable.
+ * Invoked from enter_from_user_mode_syscall_and_randomize_stack() in the
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Probably syscall_enter_from_user_mode_randomize_stack()? But the
reality is it's only ever invoked from enter_from_user_mode(), which is
below in the same file (include/linux/irq-entry-common.h).
Yes. Indeed.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help