On Wed, Jul 08 2026 at 18:04, Oleg Nesterov wrote:

On 07/08, Thomas Gleixner wrote:

quoted

On Wed, Jul 08 2026 at 09:43, Jinjie Ruan wrote:

quoted

The return value of __seccomp_filter is checked in the wrong way, check
-1 should be replaced with check false, maybe:

-               if (__seccomp_filter(this_syscall, true))
-                       return -1;
+               if (!__seccomp_filter(this_syscall, true))
+                       return false;

Or simply

	return __seccomp_filter(this_syscall, true);

and remove "return true" below ?

Duh. Obvious now that you point it out :)

Either way, I personally like this change, I was always confused by these -1's.

Welcome to the club!