Re: [patch 01/18] powerpc: Move stack randomization after... | linuxppc-dev

[patch 00/18] entry: Consolidate and rework syscall entry handling · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
[patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode() · Shrikanth Hegde <hidden> · 2026-07-08
Re: [patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 02/18] randomize_kstack: Provide add_random_kstack_offset_irqsoff() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 02/18] randomize_kstack: Provide add_random_kstack_offset_irqsoff() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 02/18] randomize_kstack: Provide add_random_kstack_offset_irqsoff() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 02/18] randomize_kstack: Provide add_random_kstack_offset_irqsoff() · Kees Cook <kees@kernel.org> · 2026-07-09
Re: [patch 02/18] randomize_kstack: Provide add_random_kstack_offset_irqsoff() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 03/18] entry: Provide [syscall_]enter_from_user_mode_randomize_stack() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 03/18] entry: Provide [syscall_]enter_from_user_mode_randomize_stack() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 03/18] entry: Provide [syscall_]enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 03/18] entry: Provide [syscall_]enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 03/18] entry: Provide [syscall_]enter_from_user_mode_randomize_stack() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 03/18] entry: Provide [syscall_]enter_from_user_mode_randomize_stack() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 04/18] loongarch/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 04/18] loongarch/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 04/18] loongarch/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 04/18] loongarch/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 04/18] loongarch/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 05/18] powerpc/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 05/18] powerpc/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 05/18] powerpc/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 05/18] powerpc/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 05/18] powerpc/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 06/18] riscv/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 06/18] riscv/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 06/18] riscv/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 06/18] riscv/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 06/18] riscv/syscall: Use syscall_enter_from_user_mode_randomize_stack() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Sven Schnelle <svens@linux.ibm.com> · 2026-07-08
Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 07/18] s390/syscall: Use enter_from_user_mode_randomize_stack() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 08/18] x86/syscall: Use [syscall_]enter_from_user_mode_randomize_stack() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 08/18] x86/syscall: Use [syscall_]enter_from_user_mode_randomize_stack() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 08/18] x86/syscall: Use [syscall_]enter_from_user_mode_randomize_stack() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 08/18] x86/syscall: Use [syscall_]enter_from_user_mode_randomize_stack() · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 08/18] x86/syscall: Use [syscall_]enter_from_user_mode_randomize_stack() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 09/18] entry: Remove syscall_enter_from_user_mode() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 09/18] entry: Remove syscall_enter_from_user_mode() · Radu Rendec <hidden> · 2026-07-08
Re: [patch 09/18] entry: Remove syscall_enter_from_user_mode() · Thomas Gleixner <tglx@kernel.org> · 2026-07-08
Re: [patch 09/18] entry: Remove syscall_enter_from_user_mode() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 09/18] entry: Remove syscall_enter_from_user_mode() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 10/18] entry: Use syscall number instead of rereading it · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 10/18] entry: Use syscall number instead of rereading it · Radu Rendec <hidden> · 2026-07-08
Re: [patch 10/18] entry: Use syscall number instead of rereading it · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 10/18] entry: Use syscall number instead of rereading it · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 10/18] entry: Use syscall number instead of rereading it · Philippe Mathieu-Daudé <hidden> · 2026-07-09
Re: [patch 10/18] entry: Use syscall number instead of rereading it · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Jinjie Ruan <hidden> · 2026-07-08
Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Thomas Gleixner <tglx@kernel.org> · 2026-07-08
Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Oleg Nesterov <oleg@redhat.com> · 2026-07-08
Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Thomas Gleixner <tglx@kernel.org> · 2026-07-08
Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Kees Cook <kees@kernel.org> · 2026-07-09
Re: [patch 11/18] seccomp, treewide: Rename and convert __secure_computing() to return boolean · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Oleg Nesterov <oleg@redhat.com> · 2026-07-08
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Geert Uytterhoeven <geert@linux-m68k.org> · 2026-07-09
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Radu Rendec <hidden> · 2026-07-09
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Michal Suchánek <hidden> · 2026-07-10
Re: [patch 12/18] ptrace, treewide: Rename ptrace_report_syscall_entry() to ptrace_report_syscall_permit_entry() · Oleg Nesterov <oleg@redhat.com> · 2026-07-10
[patch 13/18] entry: Make trace_syscall_enter() return type bool · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Michal Suchánek <hidden> · 2026-07-08
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Thomas Gleixner <tglx@kernel.org> · 2026-07-08
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Thomas Gleixner <tglx@kernel.org> · 2026-07-08
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · David Laight <hidden> · 2026-07-09
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Michal Suchánek <hidden> · 2026-07-10
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Oleg Nesterov <oleg@redhat.com> · 2026-07-10
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Michal Suchánek <hidden> · 2026-07-10
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Oleg Nesterov <oleg@redhat.com> · 2026-07-10
Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool · Michal Suchánek <hidden> · 2026-07-10
[patch 14/18] entry: Make return type of syscall_trace_enter() bool · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 14/18] entry: Make return type of syscall_trace_enter() bool · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 15/18] x86/entry: Make syscall functions static · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 15/18] x86/entry: Make syscall functions static · Jinjie Ruan <hidden> · 2026-07-09
Re: [patch 15/18] x86/entry: Make syscall functions static · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
[patch 16/18] x86/entry: Get rid of the sys_ni_syscall() indirection · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 16/18] x86/entry: Get rid of the sys_ni_syscall() indirection · Jinjie Ruan <hidden> · 2026-07-09
[patch 17/18] x86/entry: Simplify the syscall number logic · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
[patch 18/18] entry, treewide: Make syscall_enter_from_user_mode[_work]() indicate syscall execution · Thomas Gleixner <tglx@kernel.org> · 2026-07-07
Re: [patch 18/18] entry, treewide: Make syscall_enter_from_user_mode[_work]() indicate syscall execution · Shrikanth Hegde <hidden> · 2026-07-08
Re: [patch 18/18] entry, treewide: Make syscall_enter_from_user_mode[_work]() indicate syscall execution · Thomas Gleixner <tglx@kernel.org> · 2026-07-08
Re: [patch 18/18] entry, treewide: Make syscall_enter_from_user_mode[_work]() indicate syscall execution · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09
Re: [patch 00/18] entry: Consolidate and rework syscall entry handling · Mukesh Kumar Chaurasiya <hidden> · 2026-07-09

Re: [patch 01/18] powerpc: Move stack randomization after syscall_enter_from_user_mode()

From: Mukesh Kumar Chaurasiya <hidden>
Date: 2026-07-09 18:32:47
Also in: linux-alpha, linux-arch, linux-doc, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, linux-um, lkml, loongarch, sparclinux

On Tue, Jul 07, 2026 at 09:05:58PM +0200, Thomas Gleixner wrote:

add_random_kstack_offset() is invoked before syscall_enter_from_user_mode()
establishes state. That's wrong because add_random_kstack_offset() calls
into instrumentable code.

Move it after syscall_enter_from_user_mode() to ensure that state is
correctly established.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Shrikanth Hegde <redacted>
Cc: linuxppc-dev@lists.ozlabs.org

Thanks for fixing this.

Reviewed-by: Mukesh Kumar Chaurasiya (IBM) <redacted>

[...]

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help