Re: [PATCH v4 14/23] powerpc/syscall: Save r3 in regs->orig_r3

Le 26/01/2021 à 11:18, Nicholas Piggin a écrit :

Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am:

quoted

Save r3 in regs->orig_r3 in system_call_exception()

Signed-off-by: Christophe Leroy <redacted>
---
  arch/powerpc/kernel/entry_64.S | 1 -
  arch/powerpc/kernel/syscall.c  | 2 ++
  2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S
index aa1af139d947..a562a4240aa6 100644
--- a/arch/powerpc/kernel/entry_64.S
+++ b/arch/powerpc/kernel/entry_64.S

@@ -278,7 +278,6 @@ END_BTB_FLUSH_SECTION
  	std	r10,_LINK(r1)
  	std	r11,_TRAP(r1)
  	std	r12,_CCR(r1)
-	std	r3,ORIG_GPR3(r1)
  	addi	r10,r1,STACK_FRAME_OVERHEAD
  	ld	r11,exception_marker@toc(r2)
  	std	r11,-16(r10)		/* "regshere" marker */

This misses system_call_vectored.

Oops yes, this patch was cooked before SCV where introduced. Fixes in v5.

Thanks
Christophe