RE: [Qemu-ppc] [RFC PATCH 04/17] KVM: PPC64: booke: Add guest computation mode for irq delivery

-----Original Message-----
From: Alexander Graf [mailto:agraf@suse.de]
Sent: Wednesday, July 04, 2012 4:41 PM
To: Caraman Mihai Claudiu-B02008
Cc: kvm-ppc@vger.kernel.org; kvm@vger.kernel.org; linuxppc-
dev@lists.ozlabs.org; qemu-ppc@nongnu.org
Subject: Re: [Qemu-ppc] [RFC PATCH 04/17] KVM: PPC64: booke: Add guest
computation mode for irq delivery
=20
=20
On 25.06.2012, at 14:26, Mihai Caraman wrote:

quoted

Signed-off-by: Mihai Caraman <redacted>
---
arch/powerpc/kvm/booke.c |    8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index d15c4b5..93b48e0 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c

@@ -287,6 +287,7 @@ static int kvmppc_booke_irqprio_deliver(struct

kvm_vcpu *vcpu,

quoted

	bool crit;
	bool keep_irq =3D false;
	enum int_class int_class;
+	ulong msr_cm =3D 0;

	/* Truncate crit indicators in 32 bit mode */
	if (!(vcpu->arch.shared->msr & MSR_SF)) {

@@ -299,6 +300,10 @@ static int kvmppc_booke_irqprio_deliver(struct

kvm_vcpu *vcpu,

quoted

	/* ... and we're in supervisor mode */
	crit =3D crit && !(vcpu->arch.shared->msr & MSR_PR);

+#ifdef CONFIG_64BIT
+	msr_cm =3D vcpu->arch.epcr & SPRN_EPCR_ICM ? MSR_CM : 0;
+#endif

=20
No need for the ifdef, no?. Just mask EPCR_ICM out in the 32-bit host
case, then this check is always false on 32-bit hosts.

It will break e500v2. epcr field is declared only for CONFIG_KVM_BOOKE_HV,
we can limit to this instead of CONFIG_64BIT.

-Mike