Thread (43 messages) 43 messages, 6 authors, 2011-05-20

Re: [PATCH 2/7] [RFC] add bluegene entry to cputable

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2011-05-20 01:51:04
Also in: lkml

On Thu, 2011-05-19 at 20:08 -0500, Eric Van Hensbergen wrote:
On Thu, May 19, 2011 at 7:35 PM, Benjamin Herrenschmidt
[off-list ref] wrote:
quoted
On Wed, 2011-05-18 at 16:24 -0500, Eric Van Hensbergen wrote:
quoted
+             .dcache_bsize           = 32,
+             .cpu_setup              = __setup_cpu_460gt,
                                           ^^^^^^^^^^^^^^^^^^
Are you sure ?
That surprised me too, I figured it must have been a close enough
match (at least in the 2.6.29.1 time frame which is where I'm trying
to merge the BG/P patches up from.  The kittyhawk patches don't even
use this, so its possible we could just remove it.

_GLOBAL(__setup_cpu_460ex)
_GLOBAL(__setup_cpu_460gt)
        mflr    r4
        bl      __init_fpu_44x
        bl      __fixup_440A_mcheck
        mtlr    r4
        blr

Looks like the 460 setup invokes a bunch of 440 calls!  Would you
prefer I setup my own entry point (setup_cpu_bgp or setup_cpu_450)
which makes the same calls?
Yes, add an entry. 460's are just 440's btw :-)

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help