Re: [PATCH 3/7] [RFC] add support for BlueGene/P FPU
From: Michael Neuling <hidden>
Date: 2011-05-20 00:43:42
Also in:
lkml
quoted
quoted
quoted
quoted
quoted
Eric,quoted
This patch adds save/restore register support for the BlueGene/P double hummer FPU.What does this mean? =3DA0Needs more details here.okay, I've changed it a bit in [V2], if you want more I can do my best.If you can describe the whole primary and secondary registers that'd be cool. =A0ASCII art would be awesome! :-)You sure you don't just want a bitfield.conf? :)
hehe, maybe an interpretive dance video posted on youtube?
I'll do my best, but my ASCII art isn't what it used to be. I'll also include a reference to the PDF.
Something self contained in the comments would be great as external links tend to disappear.
quoted
quoted
quoted
Ok, sounds like there is 32*8*2 bytes of data, rather than the normal 32*8 bytes for FP only (ignoring VSX). If this is the case, then you'll need make 'fpr' in the thread struct bigger which you can do by setting TS_FPRWIDTH = 2 like we do for VSX.Okay - so basically what I have now and TS_FPRWIDTH=2 ?
Yes.
quoted
quoted
Since it isn't available on other chips, shoudl it just be PPC_BGP_FPU or PPC_BGP_DOUBLE_FPU?I'd probably still prefer it disassociated with the CPU name, but we are really bike shedding here. =A0I'm not too fussed.I'll leave it separate and switch it to PPC_FP2 (or would you prefer PPC_FP2_FPU to make it clear) since the public PDF refers to it this way.
PPC_FPU_FP2 would be my vote.
If that all sounds good, I'll spin [V3] tomorrow.
Thanks! Mikey