Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept
From: Tony Breeds <hidden>
Date: 2008-02-14 03:48:42
On Tue, Feb 12, 2008 at 01:08:25AM -0600, Manish Ahuja wrote:
quoted hunk ↗ jump to hunk
Initial patch for reserving memory in early boot, and freeing it later. If the previous boot had ended with a crash, the reserved memory would contain a copy of the crashed kernel data. Signed-off-by: Manish Ahuja <redacted> Signed-off-by: Linas Vepstas <redacted> ---- arch/powerpc/kernel/prom.c | 50 ++++++++++++++++++++ arch/powerpc/kernel/rtas.c | 32 +++++++++++++ arch/powerpc/platforms/pseries/Makefile | 1 arch/powerpc/platforms/pseries/phyp_dump.c | 71 +++++++++++++++++++++++++++++ include/asm-powerpc/phyp_dump.h | 38 +++++++++++++++ include/asm/rtas.h | 3 + 6 files changed, 195 insertions(+) Index: 2.6.24-rc5/include/asm-powerpc/phyp_dump.h ===================================================================--- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ 2.6.24-rc5/include/asm-powerpc/phyp_dump.h 2008-02-12 06:12:37.000000000 -0600@@ -0,0 +1,38 @@ +/* + * Hypervisor-assisted dump + * + * Linas Vepstas, Manish Ahuja 2007 + * Copyright (c) 2007 IBM Corp.
Hi Manish, Sorry for the minor nits but this should be: --- * Linas Vepstas, Manish Ahuja 2008 * Copyright 2008 IBM Corp. --- You can optionally use the '©' symbol after word 'Copyright' but you shouldn't use '(c)' anymore. Also in at least one place you've misspelt "Copyright" Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/ Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!