Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

As noted, its fixed in patch 4. 

If its okay for this time, I will prefer to leave it there.

-Manish


Stephen Rothwell wrote:

Hi Manish,

Just a small comment.

On Tue, 12 Feb 2008 01:11:58 -0600 Manish Ahuja [off-list ref] wrote:

quoted

+	/* Is there dump data waiting for us? */
+	rtas = of_find_node_by_path("/rtas");
+	dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len);

You need an of_node_put(rtas) here.

quoted

+	if (dump_header == NULL) {
+		release_all();
+		return 0;
+	}