Re: [PATCH 6/8] pseries: phyp dump: debugging print routines.

On Tuesday 08 January 2008, Manish Ahuja wrote:

+#ifdef DEBUG
+static void print_dump_header(const struct phyp_dump_header *ph)
+{
+=A0=A0=A0=A0=A0=A0=A0printk(KERN_INFO "dump header:\n");
...
+=A0=A0=A0=A0=A0=A0=A0printk(KERN_INFO "SRSD length_copied =3D%lx\n",ph->=

kernel_data.length_copied);

+}
+#endif
+

If you move the #if to inside of the function,

=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0printk (KERN_ERR "phyp-du=

mp: unexpected error (%d) on register\n", rc);

+#ifdef DEBUG
+=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0print_dump_header (ph);
+#endif
=A0=A0=A0=A0=A0=A0=A0=A0}

=A0=A0=A0=A0=A0=A0=A0=A0}
+#ifdef DEBUG
+=A0=A0=A0=A0=A0=A0=A0print_dump_header (dump_header);
+#endif

you don't need the #ifdefs here.

	Arnd <><