Thread (64 messages) flat view 64 messages, 10 authors, 2008-02-15

Re: [PATCH 4/8] pseries: phyp dump: use sysfs to release reserved mem

From: Stephen Rothwell <hidden>
Date: 2008-01-08 03:45:48

On Mon, 07 Jan 2008 18:21:57 -0600 Manish Ahuja [off-list ref] wrote:
+static int __init phyp_dump_setup(void)
+{

+	/* Is there dump data waiting for us? */
+	rtas = of_find_node_by_path("/rtas");
+	dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len);
                                                               ^^^^^^^^^^^
You could pass NULL here as header_len appears to be unused. Also you
need "of_node_put(rtas)" somewhere (probably just here would do).
+	if (dump_header == NULL) {
+		release_all();
+		return 0;
+	}
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help