RE: [PATCH 1/3] add default device trees for MPC837x MDS board

-----Original Message-----
From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On=20
Behalf Of Grant Likely
Sent: Wednesday, January 09, 2008 1:54 AM
To: Wood Scott
Cc: Li Yang; linuxppc-dev@ozlabs.org; paulus@samba.org
Subject: Re: [PATCH 1/3] add default device trees for MPC837x=20
MDS board
=20
On 1/8/08, Scott Wood [off-list ref] wrote:

quoted

On Tue, Jan 08, 2008 at 08:58:17AM -0700, Grant Likely wrote:

quoted

On 1/7/08, Li Yang [off-list ref] wrote:

quoted

+                       phy_type =3D "utmi_wide";

fsl,phy_type please.

Again, code will break.  Can we stop ambushing people=20

submitting board=20

quoted

support with complaints against existing, non-board-specific=20
code/device trees?  Fix that first, then complain if new=20

code reintroduces the crud.
=20
I disagree (about bringing up these comments).  New board=20
port is the time to bring these issue up.  It keeps the issue=20
in the forefront so it actually gets fixed.

Hi,

I agree that it's good to bring these issues up for a better standarized =
device tree definition.  It will be even better if the guidelines are =
documented rather than nuncupated on the mail list.  However, I think =
that adding new board support is independent of fixing preexistent =
issues.  I do prefer to fix these issues together with other occurrences =
by separated patches rather than respin the new board support over and =
over again.

- Leo