RE: [PATCH 3/3] USB device tree cleanups

-----Original Message-----
From: linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org=20
[mailto:linuxppc-dev-bounces+leoli=3Dfreescale.com@ozlabs.org]=20
On Behalf Of Stephen Rothwell
Sent: Tuesday, January 08, 2008 7:10 AM
To: Li Yang
Cc: linuxppc-dev@ozlabs.org; paulus@samba.org
Subject: Re: [PATCH 3/3] USB device tree cleanups
=20
On Mon,  7 Jan 2008 20:03:20 +0800 Li Yang=20
[off-list ref] wrote:

quoted

+++ b/arch/powerpc/sysdev/fsl_soc.c

@@ -533,9 +533,7 @@ static int __init fsl_usb_of_init(void)
 		*usb_dev_dr_client =3D NULL;
 	int ret;

=20
-	for (np =3D NULL, i =3D 0;
-	     (np =3D of_find_compatible_node(np, "usb",=20

"fsl-usb2-mph")) !=3D NULL;

quoted

-	     i++) {
+	for_each_compatible_node(np, NULL, "fsl-usb2-mph") {

=20
'i' is no longer being updated (or indeed set to anything)=20
but is still used in the loop - at least in Paulus' current tree).

Good catch. My careless mistake.  Thanks.

- Leo