Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver
From: Olof Johansson <hidden>
Date: 2007-12-02 03:55:31
Also in:
linux-ide
From: Olof Johansson <hidden>
Date: 2007-12-02 03:55:31
Also in:
linux-ide
On Tue, Nov 27, 2007 at 06:39:08PM +0300, Anton Vorontsov wrote:
+static struct of_device_id pata_of_platform_match[] = {
+ { .compatible = "pata-platform", },
+};On top of previous comment about the compatible string being inappropriate: You should add a MODULE_DEVICE_TABLE() entry for this. Dave Woodhouse pointed out it's needed for autoloading modules (i.e. by the fedora installer, etc). -Olof