Thread (39 messages) 39 messages, 9 authors, 2007-12-02

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

From: Anton Vorontsov <hidden>
Date: 2007-11-30 12:05:00
Also in: linux-ide

On Fri, Nov 30, 2007 at 02:43:50PM +0300, Sergei Shtylyov wrote:
Anton Vorontsov wrote:
quoted
quoted
quoted
Remaining question: any preferred name for that property? pio-mode okay?
It's assuming that PIO6 capable bus supports PIO0 as well, thus no mask.
quoted
quoted
 I've already suggested "generic". A name "simple" also comes to my mind.
quoted
You've misread my question. I didn't ask about driver name, but pio-mode
property.
   Probably "max-pio-mode" is a better variant.
Why? pio-mode in pata-platform context is just something highly
dependent on hardware, can not be touched. And we're passing
pio-mode information from the hardware dependent source --
device tree.

The only difference between pata-platform's max-pio-mode and
dedicated ata driver's pio-mode is that that for the first case
bus already configured for specified mode, and for the second
case dedicated driver should actually use this information
to configure hardware.

No need for max- prefix, I think.

-- 
Anton Vorontsov
email: cbou@mail.ru
backup email: ya-cbou@yandex.ru
irc://irc.freenode.net/bd2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help