Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver
From: Stephen Rothwell <hidden>
Date: 2007-11-28 00:41:11
Also in:
linux-ide
Attachments
- (unnamed) [application/pgp-signature] 189 bytes
From: Stephen Rothwell <hidden>
Date: 2007-11-28 00:41:11
Also in:
linux-ide
On Tue, 27 Nov 2007 18:39:08 +0300 Anton Vorontsov [off-list ref] wrote:
+static int __devinit pata_of_platform_probe(struct of_device *ofdev,
+ const struct of_device_id *match)
+{
+ uint32_t *prop;Make this "const uint32_t *prop" or (more kernel like) "const u32 *prop" ...
+ prop = (uint32_t *)of_get_property(dn, "ioport-shift", NULL);
then you don't need this cast. Anytime you use a cast to get rid of "const", is probably a mistake. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/