On Nov 27, 2007, at 9:49 AM, Sergei Shtylyov wrote:

Hello.

Anton Vorontsov wrote:

quoted

This patch adds localbus and pata nodes to use CF IDE interface
on MPC8349E-mITX boards.

quoted

Patch also adds code to probe localbus.

quoted

Signed-off-by: Anton Vorontsov <redacted>
---
arch/powerpc/boot/dts/mpc8349emitx.dts    |   17 ++++++++++++++++-
arch/powerpc/platforms/83xx/mpc834x_itx.c |   17 +++++++++++++++++
2 files changed, 33 insertions(+), 1 deletions(-)

quoted

diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/=20=

quoted

boot/dts/mpc8349emitx.dts
index 5072f6d..7a97068 100644

--- a/arch/powerpc/boot/dts/mpc8349emitx.dts
+++ b/arch/powerpc/boot/dts/mpc8349emitx.dts

@@ -249,6 +249,21 @@

		device_type =3D "pci";
	};

+	localbus@e0005000 {
+		#address-cells =3D <2>;
+		#size-cells =3D <1>;
+		compatible =3D "fsl,mpc8349emitx-localbus",

   Board compatible bus?

quoted

+			     "fsl,mpc8349e-localbus",
+			     "fsl,pq2pro-localbus";
+		reg =3D <e0005000 d8>;
+		ranges =3D <3 0 f0000000 210>;

-
+		pata@3,0 {
+			compatible =3D "fsl,mpc8349emitx-pata", =

"pata-platform";

quoted

+			reg =3D <3 0 10 3 20c 4>;
+			ioport-shift =3D <1>;

   Bleh... that shift again. And this is surely not a good name for a
property (where's I/O ports in your case?) -- why not call it "reg-=20
shift"
(well, I'd call it "reg-size" or "reg-stride" myself :-)?

I'm coming into this late, but if ioport-shift applies to reg (which I =20=

think it does) it should really be called "reg-shift".  The ePAPR is =20
using that property name:

Specifies in bytes how far the discrete device registers are separated =20=

from each other. The
individual register location is calculated by using following formula: =20=

=93registers address=94 <<
reg-shift. If unspecified the default value is 0.

- k