Re: [RFC][PATCH 6/8] Walnut DTS

On Wed, Jul 11, 2007 at 12:55:31PM -0500, Josh Boyer wrote:

On Wed, 2007-07-11 at 19:49 +0200, Segher Boessenkool wrote:

quoted

quoted

+	UIC0: interrupt-controller0 {

Why not just "interrupt-controller"?

Copy/paste error from Ebony DTS, which has multiple UICs.  Will fix.

quoted

quoted

+		#address-cells = <0>;
+		#size-cells = <0>;

No need for these.

Ok.

quoted

quoted

+	plb {
+		ranges;

Please make the valid address ranges explicit here.

Meaning what exactly?  I thought just specifying "ranges;" simply said
"the addresses from this node don't have any translation from the parent
node" (or something like that).

quoted

quoted

+		SDRAM0: memory-controller {
+			compatible = "ibm,sdram-405gp", "ibm,sdram-440gp";

It's a bit weird to mention 440 here, since 405 is older.
Not a real problem, but if you still can change all relevant
OS code and device trees, I'd swap it around (make 440 trees
include the 405 "compatible" value).  Can you still do that
or is there a too big installed base already?

The installed base for 440 exists of exactly 1 completely non-functional
board ;).  I can change it.

And I don't think we even actually look at this compatible property in
practice.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson