Re: [RFC][PATCH 6/8] Walnut DTS
From: Segher Boessenkool <hidden>
Date: 2007-07-17 14:26:46
Right. See, there are people like me that don't know what the default values are/should be. Having them explicitly listed, even if it's redundant, serves as a good learning aid.
_Only_ if it's redundant. Not if it has a meaning different from having the property not there at all.
Now, realistically I do know what the default is in this case. But I only learned that recently. With hopefully more people starting to port things over to arch/powerpc it might be a good idea to document them at least.
Definitely, we need more good examples, and maybe some public stonings or something like that.
Otherwise, I fear we'd wind up repeating ourselves over and over. Could we get a 'thou shalt not rely on defaults' added to booting-without-of.txt? Or maybe something less draconian ;).
Such a statement is too vague to be meaningful. It would be a good idea in separate cases; but _do_ describe it more carefully than just talking about "defaults", and _do_ put a comment at any such entry that this is different from how Open Firmware defines this, so that people looking at the Linux code won't get hopelessly confused. Segher