On Tue, May 29, 2007 at 11:57:52AM +0200, Geert Uytterhoeven wrote:

On Tue, 29 May 2007, Christoph Hellwig wrote:

quoted

On Fri, May 25, 2007 at 10:36:14AM +0200, Geert.Uytterhoeven@sonycom.com wrote:

quoted

Add a FLASH ROM Storage Driver for the PS3:
  - Implemented as a misc character device driver
  - Uses a fixed 256 KiB buffer allocated from boot memory as the hypervisor
    requires the writing of aligned 256 KiB blocks

Looks good, but please either make the driver aware of multiple devices
even if they can't happen currently, or alternatively error out in
->probe if of some reason it's called for a second device.

ps3flash_probe() does return -EBUSY when called for a second device.

You're right, I missed that bit.