Thread (48 messages) 48 messages, 6 authors, 2007-05-30

Re: [patch 4/7] ps3: Storage Driver Probing

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2007-05-25 22:54:51
Also in: lkml

On Fri, 2007-05-25 at 21:48 +0200, Geert Uytterhoeven wrote:
quoted
quoted
+           msleep_interruptible(ms);
+           if (ms < 60000)
+                   ms <<= 1;
Is this timeout only for the disk spinup, or also for detecting
media
quoted
added at run time, like inserting a DVD? One minute timeout for
detecting a DVD would sound very long to me.
It's not for inserting DVDs, only for new devices showing up in the
repository.
Apparently new devices may keep on showing up a while after boot up,
but I
think this matters only for the kboot kernel, that's why I went with
the
exponential back-off with upper limit.
Why not just have a kthread poll at 2 second interval for new devices or
removed ones ?

(And not for request processing)

Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help