Thread (48 messages) 48 messages, 6 authors, 2007-05-30

Re: [patch 5/7] ps3: Disk Storage Driver

From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-05-25 20:44:00
Also in: lkml

On Friday 25 May 2007, Geert Uytterhoeven wrote:
quoted
I don't really understand what the kthread is needed for. You probably
thought about multiple options and ended up with this, but having
a comment in front of it might be helpful.
I used a kthread because the request function of a block device driver must be
non-blocking, and ps3stor_read_write_sectors() calls wait_for_completion().
Ok, but why does it call wait_for_completion() then?
I thought you could end_that_request_* from the interrupt handler instead.

	Arnd <><
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help