On Sat, 26 May 2007, Benjamin Herrenschmidt wrote:

On Fri, 2007-05-25 at 18:18 +0200, Arnd Bergmann wrote:

quoted

quoted

+static u64 ps3stor_wait_for_completion(u64 devid, u64 tag,
+                                    unsigned int timeout)
+{
+     unsigned int retries = 0;
+     u64 res = -1, status;
+
+     for (retries = 0; retries < timeout; retries++) {
+             res =

lv1_storage_check_async_status(NOTIFICATION_DEVID, tag,

quoted

+                                                  &status);
+             if (!res)
+                     break;
+             set_current_state(TASK_INTERRUPTIBLE);
+             schedule_timeout(1);
+     }

Any reason not to use msleep(1) instead of the schedule_timeout? 

Both look equally ugly though... do you really have to poll ?

The special notification device (NOTIFICATION_DEVID = -1) is not in the
repository and AFAIK it doesn't have an interrupt attached to it.
Note that this is used during probing only.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium