On Thu, May 03, 2007 at 12:13:58PM +1000, Stephen Rothwell wrote:

On Wed, 2 May 2007 14:46:09 -0700 "Dale Farnsworth" [off-list ref] wrote:

quoted

+DECLARE_MUTEX(mv64x60_hs_lock);

Does this need to be global (it is not declared in a header file)?

Nope.  Fixed.

quoted

+	np = of_find_compatible_node(NULL, NULL, "mv64x60");
+	if (!np)
+		return 0;
+
+	pdev = platform_device_register_simple("mv64x60", 0, NULL, 0);
+	if (IS_ERR(pdev))
+		return PTR_ERR(pdev);

This error leaks a reference count on np.

Good find.  Fixed.

Stephen, thanks for taking the time to review and comment.
I'll wait to see what other comments I get before reposting.

-Dale