Re: [PATCH 10/13] powerpc: Add arch/powerpc mv64x60 PCI setup
From: Stephen Rothwell <hidden>
Date: 2007-05-03 02:13:58
On Wed, 2 May 2007 14:46:09 -0700 "Dale Farnsworth" [off-list ref] wrote:
+DECLARE_MUTEX(mv64x60_hs_lock);
Does this need to be global (it is not declared in a header file)?
+ np = of_find_compatible_node(NULL, NULL, "mv64x60");
+ if (!np)
+ return 0;
+
+ pdev = platform_device_register_simple("mv64x60", 0, NULL, 0);
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);This error leaks a reference count on np. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Attachments
- (unnamed) [application/pgp-signature] 189 bytes