Re: [PATCH 6/13] powerpc: Add arch/powerpc interrupt handler for mv64x60

On Thu, May 03, 2007 at 11:47:05AM +1000, Stephen Rothwell wrote:

On Wed, 2 May 2007 14:38:30 -0700 "Dale Farnsworth" [off-list ref] wrote:

quoted

+DEFINE_SPINLOCK(mv64x60_lock);

Does this need to be global (it is not declared in the header file)?

No, it doesn't.  I made it static.

quoted

+static u32 mv64x60_cached_low_mask  = 0;
+static u32 mv64x60_cached_high_mask = MV64X60_HIGH_GPP_GROUPS;
+static u32 mv64x60_cached_gpp_mask  = 0;

Don't initialise things to zero, please.  If you feel it is necessary,
put the "= 0" in a comment.  But generally we know that globals are
initially zero.

OK.  Thanks.

-Dale