Re: [PATCH 6/13] powerpc: Add arch/powerpc interrupt handler for mv64x60
From: Stephen Rothwell <hidden>
Date: 2007-05-03 01:47:05
On Wed, 2 May 2007 14:38:30 -0700 "Dale Farnsworth" [off-list ref] wrote:
+DEFINE_SPINLOCK(mv64x60_lock);
Does this need to be global (it is not declared in the header file)?
+static u32 mv64x60_cached_low_mask = 0; +static u32 mv64x60_cached_high_mask = MV64X60_HIGH_GPP_GROUPS; +static u32 mv64x60_cached_gpp_mask = 0;
Don't initialise things to zero, please. If you feel it is necessary, put the "= 0" in a comment. But generally we know that globals are initially zero. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
Attachments
- (unnamed) [application/pgp-signature] 189 bytes