Re: [PATCH 17/30] brcmfamc: remove unnecessary call to brcmf_sdiod_set_backplane_window()

Hi Arend,

On Wed, Aug 23, 2017 at 5:38 AM, Arend van Spriel
[off-list ref] wrote:

On 22-08-17 14:50, Julian Calaby wrote:

quoted

Hi Ian,

On Tue, Aug 22, 2017 at 9:25 PM, Ian Molton [off-list ref] wrote:

quoted

All functions that might require the window address changing call
brcmf_sdiod_set_backplane_window() prior to access. Thus resetting
the window is not required.

Wouldn't it be more safe to write these sorts of functions so that
they set the window themselves instead of relying on the caller?

The function brcmf_sdiod_set_backplane_window() is a helper function by
which these sorts of functions set the window themselves. It would be
duplicating too much code as setting the window involves three register
accesses (or so) on the device.

I don't think I explained my point well.

The description of this patch implies that this method
brcmf_sdiod_ramrw(), now relies on the window being set elsewhere
before it's called.

I'm asking why we can't move the setting of the window inside this
function and remove any redundant calls to
brcmf_sdiod_set_backplane_window() outside of it.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/