Re: [PATCH v5] brcmfmac cleanup

On 22/08/17 20:41, Arend van Spriel wrote:

On 22-08-17 13:25, Ian Molton wrote:

quoted

Hi folks,

Arend, as requested - a respin to take account of your comments.

Unfortunately, although I've only included the patches you requested
from v4,
breaking out some of the simpler changes (whitespace, macos, etc.) has
grown
the set back up to 30 patches. I hope this is OK.

:-( Grumbl, you also introduced some new ideas, eg. patch 26/30.

Oh, yeah. Forgot about that one, but its so uncontroversial I didn't see
the harm.

The same lines were touched in 25/30 and I didn't want to sneak the
change in there, as it felt dishonest to do so.

I reviewed 15 patches that mostly involved in cleaning up bcmsdh.c. My
hopes were that you addressed those 15 patches with a respin to get that
part at least in for 4.14 as we are steadily moving towards the merge
window. Maybe you did, but going from 15 to 30 feels like things are
moving in the wrong direction. I will dig through it again.

I may have misunderstood, but you wrote:

"From this series I reviewed patches 1 upto and including patch 15, and
patches 29 through 34. Please rework those as requested and resubmit
them. Please also resubmit the remaining patch after that"

I took that to mean you wanted a respin that included 1-15 and 29-34.

- That would have been 21 patches on its own, but a couple of the later
ones drew in dependencies, and you asked me to break up a couple of
others, eg. whitespace.

Thats how we arrived at 30 patches again. I'm not attempting to take the
piss, I swear :)

I do appreciate the review. I've replied to your emails on the v4
series, so if you have a question as to why I've done something, you may
well find the answer there.

-Ian